When the parser is unable to resolve a path, give the user supplied path in the error. #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ath in the error.
JamesMessinger
requested changes
Mar 5, 2018
| * @returns {Pointer} | ||
| */ | ||
| $Ref.prototype.resolve = function (path, options) { | ||
| var pointer = new Pointer(this, path); | ||
| $Ref.prototype.resolve = function (path, options, originalPath) { |
There was a problem hiding this comment.
I don't see anywhere where this method is called with the new parameter. Am I missing something? Or is the parameter always undefined? If the latter, then we can remove the parameter from here and from the Pointer constructor.
There was a problem hiding this comment.
There was a problem hiding this comment.
thanks. Not sure how I missed that
JamesMessinger
approved these changes
Mar 17, 2018
|
json-schema-ref-parser v5.0.0 has been published to npm and includes this fix. Thanks again for your help! |
|
Does this also fix the issue with the custom resolver not getting the original $ref? (i'll test when i get a chance) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix APIDevTools/swagger-parser#76.
I'm a little out of my depth here but as far as I can tell this change should work in all-cases.